build(python)!: Drop support for Python 3.8 which reached EOL and add expose support for 3.13 #1298
Conversation
noirbizarre
force-pushed
the
python/3.9-3.13
branch
from
329df37 to
fd2898f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
+ Coverage 97.33% 97.58% +0.24%
==========================================
Files 42 55 +13
Lines 2104 2607 +503
==========================================
+ Hits 2048 2544 +496
- Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
oops. it seems this bump major version 😱 @woile @noirbizarre should we revert this and merge this to v4 instead? |
|
or we can just make the |
|
Let's leave it, technically this is proper semver 😅 |
|
Agreed, let's stick to semver. It means we will have at least a major a year. However, maybe this not wanted, dropping a Python version reaching EOL should not be considered a breaking change (as actually there is no API breakage) and I should not tag the commit breaking next time 🤷♂️ |
|
Sounds good 👍 Just want to make sure we are all ok with it (frequent breaking changes actually don't bother me that much anyway) But I'm wondering whether we could create a way to block merging accidental breaking change? e.g, allow only certain branch like |
Description
Drop support for Python 3.8 which reached End Of Life (cf. https://devguide.python.org/versions/)
Expose support for Python 3.13 which is already tested in CI but not in the package metadata.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
CI should be sufficient
Additional context
N/A